reload db-credentials-file upon SIGHUP #4514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Charis <acharis@hubspot.com>
Signed-off-by: Alex Charis <acharis@hubspot.com>
sougou
reviewed
Jan 12, 2019
go/vt/dbconfigs/credentials.go
Outdated
| sigChan := make(chan os.Signal, 1) | ||
| signal.Notify(sigChan, syscall.SIGHUP) | ||
| go func() { | ||
| for { |
There was a problem hiding this comment.
Use for _ = range sigChan {
There was a problem hiding this comment.
gofmt changed that to for range sigChan
There was a problem hiding this comment.
and i made the same change the two other places i saw the bare for
go/vt/dbconfigs/credentials.go
Outdated
| go func() { | ||
| for { | ||
| <-sigChan | ||
| fcs, ok := AllCredentialsServers["file"].(*FileCredentialsServer) |
There was a problem hiding this comment.
Inline this with if fcs...; ok {
Signed-off-by: Alex Charis <acharis@hubspot.com>
sougou
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why we want this is a bit of a long story, but reloading creds on receipt of SIGHUP seems like a good idea.
Signed-off-by: Alex Charis acharis@hubspot.com