Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a test to check regressions in parser #4527

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Adds a test to check regressions in parser #4527

merged 1 commit into from
Jan 16, 2019

Conversation

rafael
Copy link
Member

@rafael rafael commented Jan 15, 2019

Desc

@rafael rafael requested a review from sougou as a code owner January 15, 2019 18:44
@sougou
Copy link
Contributor

sougou commented Jan 16, 2019

The test failed, which means it passed :). Now that I submitted your fix, can you rebase, and we'll verify that it goes green.

@rafael
Adds a test to check regressions in parser
7c36faa 
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
@rafael rafael force-pushed the add-test-check-regressions-in-parser branch from bc7b38c to 7c36faa Compare January 16, 2019 06:05
@rafael
Copy link
Member Author

rafael commented Jan 16, 2019

Yei! It works

@sougou sougou merged commit 360d5cd into vitessio:master Jan 16, 2019
@rafael rafael mentioned this pull request Jan 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou sougou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafael @sougou