Allow STRICT_ALL_TABLES when enforcing strict_trans_tables #4534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bs to be configured with STRICT_ALL_TABLES when vitess is enforcing STRICT_TRANS_TABLES (-enforce_strict_trans_tables=true) Signed-off-by: Miriam Lauter <lauter.miriam@gmail.com>
sougou
approved these changes
Jan 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since STRICT_ALL_TABLES is a superset of STRICT_TRANS_TABLES, allow dbs to be configured with STRICT_ALL_TABLES when vitess is enforcing STRICT_TRANS_TABLES (-enforce_strict_trans_tables=true)
Signed-off-by: Miriam Lauter lauter.miriam@gmail.com