Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update func #4565

Merged
merged 3 commits into from
Jan 30, 2019
Merged

Update func #4565

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76b1a6b
Update func
xichengliudui Jan 30, 2019
9dfff49
update pull request
xichengliudui Jan 30, 2019
2b6dda4
update pull request
xichengliudui Jan 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go/vt/vtgate/executor_select_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ func TestSelectKeyRangeUnique(t *testing.T) {
func TestSelectIN(t *testing.T) {
executor, sbc1, sbc2, sbclookup := createExecutorEnv()

// Constant in IN is just a number, not a bind variable.
// Constant IN is just a number, not a bind variable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the edit is wrong. a clearer way to say this is Constant in IN clause.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do I need to change?

_, err := executorExec(executor, "select id from user where id in (1)", nil)
if err != nil {
t.Error(err)
Expand All @@ -614,7 +614,7 @@ func TestSelectIN(t *testing.T) {
t.Errorf("sbc2.Queries: %+v, want nil\n", sbc2.Queries)
}

// Constant in IN is just a couple numbers, not bind variables.
// Constant IN is just a couple numbers, not bind variables.
// They result in two different queries on two shards.
sbc1.Queries = nil
sbc2.Queries = nil
Expand Down
4 changes: 2 additions & 2 deletions go/vt/vtgate/executor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1841,7 +1841,7 @@ func TestExecutorUnrecognized(t *testing.T) {
func TestExecutorMessageAckSharded(t *testing.T) {
executor, sbc1, sbc2, _ := createExecutorEnv()

// Constant in IN is just a number, not a bind variable.
// Constant IN is just a number, not a bind variable.
ids := []*querypb.Value{{
Type: sqltypes.VarChar,
Value: []byte("1"),
Expand All @@ -1860,7 +1860,7 @@ func TestExecutorMessageAckSharded(t *testing.T) {
t.Errorf("sbc2.MessageIDs: %+v, want nil\n", sbc2.MessageIDs)
}

// Constant in IN is just a couple numbers, not bind variables.
// Constant IN is just a couple numbers, not bind variables.
// They result in two different MessageIDs on two shards.
sbc1.MessageIDs = nil
sbc2.MessageIDs = nil
Expand Down