Use a more specific "in use" message for the tx killer's rollback #4576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Someone who accidentally made a huge transaction asked what this error meant: "vttablet: rpc error: code = Aborted desc = transaction 1548379105148705713: in use: for rollback" It's less clear than the typical transaction killed error because the transaction was so large that rolling it back probably took some time. This diff changes the in use reason to "for tx killer rollback" which will hopefully be more clear. Signed-off-by: David Weitzman <dweitzman@pinterest.com>
sougou
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone who accidentally made a huge transaction asked what this error meant:
"vttablet: rpc error: code = Aborted desc = transaction 1548379105148705713: in use: for rollback"
It's less clear than the typical transaction killed error because the transaction was so large that
rolling it back probably took some time. This diff changes the in use reason to "for tx killer rollback"
which will hopefully be more clear.
Signed-off-by: David Weitzman dweitzman@pinterest.com