Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CRC32 usage from zlib -> native go hash/crc32 IEEE #4590

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Change CRC32 usage from zlib -> native go hash/crc32 IEEE #4590

merged 1 commit into from
Feb 5, 2019

Conversation

teejae
Copy link
Contributor

@teejae teejae commented Feb 5, 2019

Removes last vestiges of CGO from vitess codebase.

Signed-off-by: Toliver Jue toliver@planetscale.com

Change CRC32 usage from zlib -> native go hash/crc32
fe6ab9c 
Signed-off-by: Toliver Jue <toliver@planetscale.com>
@teejae teejae requested a review from sougou as a code owner February 5, 2019 01:43
@teejae teejae changed the title Change CRC32 usage from zlib -> native go hash/crc32 Change CRC32 usage from zlib -> native go hash/crc32 IEEE Feb 5, 2019
sougou
sougou approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally! No more cgo. One should be able to go get any vitess binary after this.

@sougou sougou merged commit 9094685 into vitessio:master Feb 5, 2019
@vitalyisaev2
Copy link

@teejae @sougou Sorry, but was cgzip library just dropped or was it moved to some other repository?

@teejae
Copy link
Contributor Author

teejae commented Feb 5, 2019

@vitalyisaev2 We had completely dropped cgzip. Are you having problems with this change?

@vitalyisaev2
Copy link

Yes, I have a project depending on cgzip. It's a pity that it will be no longer supported, but anyway I can take the cgzip sources and include it in the project directly. Thanks for prompt response)

@zmagg zmagg mentioned this pull request Mar 19, 2019
Merged
@harshit-gangal harshit-gangal deleted the teejae-vitess-crc32 branch July 17, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou sougou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teejae @vitalyisaev2 @sougou