Close result readers correctly #4592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Taylor <antaylor@squareup.com>
mpawliszyn
reviewed
Feb 5, 2019
| func (scw *SplitCloneWorker) getSourceResultReader(ctx context.Context, td *tabletmanagerdatapb.TableDefinition, state StatusWorkerState, chunk chunk, txID int64) (ResultReader, error) { | ||
| sourceReaders := make([]ResultReader, len(scw.sourceShards)) | ||
| var readers []ResultReader | ||
| defer func() { |
There was a problem hiding this comment.
Do we need to be concerned around panics?
There was a problem hiding this comment.
If you're worried about readers being nil: go's range construct treats nil as an empty list. So, there won't be a panic.
There was a problem hiding this comment.
I thought the concern was that an uncaught panic might cause the readers to not be closed.
sougou
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @deepthi @mpawliszyn @eeSeeGee