make FindSlaves keys be addresses #4595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes vitessio#4532 I didn't see a good way to test it (other than manually running the command). Signed-off-by: Scott Lanning <scott.lanning@booking.com>
|
@rafael are you familiar with this part? If not, I'll dig in. |
|
@sougou - I am not. If you could dig in that would be great. |
sougou
approved these changes
Feb 13, 2019
There was a problem hiding this comment.
Looks like this code path is only used by validate replication. So, it's probably ok for now.
Most likely, this will break (or is already broken) for places where there are internal vs external IPs (like aws). But I believe same problem exists w.r.t. hostnames.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4532
I didn't see a good way to test it (other than manually running the command).
Signed-off-by: Scott Lanning scott.lanning@booking.com