Return TabletManager.GetPermissions results in a consistent order #4694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids false alarms from vtctl ValidatePermissionsKeyspace which seems to assume the results will be in a consistent order but doesn't explicitly sort them. MyISAM does not seem to return results in a consistent order from mysql.user or mysql.db without an explicit ORDER BY. Another change: "vtctl GetPermissions" will now print a json result to stdout instead of logging an asciiproto to stderr/INFO so it's easier to examine or debug output. Signed-off-by: David Weitzman <dweitzman@pinterest.com>
sougou
approved these changes
Mar 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids false alarms from vtctl ValidatePermissionsKeyspace which
seems to assume the results will be in a consistent order but doesn't
explicitly sort them. MyISAM does not seem to return results in a
consistent order from mysql.user or mysql.db without an explicit ORDER BY.
Another change: "vtctl GetPermissions" will now print a json result to stdout
instead of logging an asciiproto to stderr/INFO so it's easier to examine or
debug output.
Signed-off-by: David Weitzman dweitzman@pinterest.com