Single round trip commit on BatchExecute #4739
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
there is no need to explicitly create a transaction. We can forward the DML
directly to the database.
around 25-30% improvement. Most of our queries are single point
inserts/updates that already use auto commit when coming from vtgates, so this
improvement is something that we've been wanting to do for a long time.
Benchmark
Setup
Results
TL;DR
Prior to this change BLACKHOLE ENGINE:
The following parameters where passed to vtbench:
Prior to this change REAL ENGINE:
The following parameters where passed to vtbench:
New Build BLACKHOLE ENGINE:
The following parameters where passed to vtbench:
New Build REAL ENGINE:
The following parameters where passed to vtbench: