Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes debugging purpose code #4753

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Removes debugging purpose code #4753

merged 1 commit into from
Mar 25, 2019

Conversation

rafael
Copy link
Member

@rafael rafael commented Mar 25, 2019

Description

  • When I was writing this test, added this code to debug some errors when the code was not fully done. Then I remove the logging, but left this empty checks there. This is safe to remove.

Signed-off-by: Rafael Chacon rafael@slack-corp.com

@rafael
Removes debugging purpose code
095cd67 
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
@rafael rafael requested a review from sougou as a code owner March 25, 2019 22:12
@rafael rafael mentioned this pull request Mar 25, 2019
Merged
9 tasks
deepthi
deepthi approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafael rafael merged commit 933307f into vitessio:master Mar 25, 2019
@rafael rafael deleted the cleanup-test-code branch March 25, 2019 23:31
@rafael rafael mentioned this pull request Apr 2, 2019
Merged
systay pushed a commit that referenced this pull request Jul 22, 2024
@planetscale-actions-bot
cherry pick of 15538 (#4753)
7566ba2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafael @deepthi