tableacls: remove deprecated -legacy-table-acl option from vttablet #4756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If anyone out there is using legacy behavior, seems like it should be possible to switch to the newer behavior. The legacy behavior has a weaker understanding of what queries do and seems like if anything would be stricter than the newer behavior. Signed-off-by: David Weitzman <dweitzman@pinterest.com>
dweitzman
force-pushed
the
legacy_table_acl
branch
from
3ccd34e
to
da8d0f6
Compare
sougou
approved these changes
Mar 31, 2019
notfelineit
pushed a commit
to planetscale/vitess
that referenced
this pull request
Apr 13, 2024
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If anyone out there is using legacy behavior, seems like it should
be possible to switch to the newer behavior.
The legacy behavior has a weaker understanding of what queries do
and seems like if anything would be stricter than the newer behavior.