Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log actual error when GetSrvKeyspace fails #4757

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Mar 28, 2019

Signed-off-by: deepthi deepthi@planetscale.com

@deepthi deepthi requested a review from sougou as a code owner March 28, 2019 01:17
@deepthi deepthi requested a review from rafael March 28, 2019 01:18
go/vt/vttablet/tabletmanager/state_change.go Outdated Show resolved Hide resolved
@rafael
Copy link
Member

rafael commented Mar 28, 2019

Thank you for this fix!

Per discussion in Slack, I think in this case we should squash these commits.

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
Copy link
Member Author

deepthi commented Mar 28, 2019

Thank you for this fix!

Per discussion in Slack, I think in this case we should squash these commits.

Done.

@deepthi deepthi merged commit c91eff9 into vitessio:master Mar 29, 2019
@harshit-gangal harshit-gangal deleted the ds-log-error branch July 17, 2020 16:39
frouioui pushed a commit to planetscale/vitess that referenced this pull request Mar 26, 2024
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants