Add strong warning against production use to example init_db.sql file #4815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Toliver Jue <toliver@planetscale.com>
enisoc
reviewed
Apr 17, 2019
config/init_db.sql
Outdated
| ############################################################################### | ||
| # WARNING: This sql is *NOT* safe for production use, | ||
| # as it contains default users and passwords | ||
| # with more privileges than necessary. |
There was a problem hiding this comment.
As far as I know, the privileges given are necessary. Is there an example you see that's unnecessary?
The main thing that we intended for people to change but didn't document well enough is the passwords, especially for the users that allow remote connections.
There was a problem hiding this comment.
I've removed comment about privileges, and added comment about rotating them as necessary.
|
@teejae the second commit did not pass the DCO check, it didn't have a
signoff. Since this has already been merged I'm not sure what the best way
to fix that is, but it needs to be fixed.
…On Tue, Apr 16, 2019 at 10:12 PM Anthony Yeh ***@***.***> wrote:
Merged #4815 <#4815> into master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4815 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAXs14xeW8HL0HkrBekHGYxiGHWscm-0ks5vhq1JgaJpZM4c0B3w>
.
|
|
The single, squashed commit seems to have the DCO: 7329452 |
|
I see that now. This is confusing because github is still showing 2 commits on the PR, but looks like we should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Toliver Jue toliver@planetscale.com