Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support nested substring calls #4867

Merged
merged 1 commit into from
May 23, 2019
Merged

Support nested substring calls #4867

merged 1 commit into from
May 23, 2019

Conversation

kuba--
Copy link
Collaborator

@kuba-- kuba-- commented May 17, 2019

Signed-off-by: kuba-- kuba@sourced.tech

So far, vitess cannot parse nested SUBSTR calls. This PR adds support for queries like:

select substr(substr('foo', 1, 2), 1, 2) from t

The issue does not exist for other string functions like REPLACE.

Support nested substring calls
eff5f47 
Signed-off-by: kuba-- <kuba@sourced.tech>
@kuba-- kuba-- requested a review from sougou as a code owner May 17, 2019 09:50
@kuba-- kuba-- mentioned this pull request May 17, 2019
Closed
@kuba--
Copy link
Collaborator Author

kuba-- commented May 21, 2019

Are we OK, with this change?

@sougou
Copy link
Contributor

sougou commented May 21, 2019

I'm backlogged due to kubecon. And I'll be at Percona live next week. I'll try to find time in the middle.

sougou
sougou approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change 👍

@sougou sougou merged commit eb2d057 into vitessio:master May 23, 2019
@kuba-- kuba-- deleted the nested-substring branch May 31, 2019 22:08
systay pushed a commit that referenced this pull request Jul 22, 2024
@planetscale-actions-bot
cherry pick of 15618 (#4867)
aeb706f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou sougou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuba-- @sougou