Add -keep_logs_by_mtime flag for purging old log files by mtime instead of ctime + bugfix
#4890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtime instead of ctime. (Alternative solution for 7864985.) Signed-off-by: Adam Saponara <as@php.net>
sougou
approved these changes
Jun 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative solution for 7864985. Purging by mtime ensures we only purge logs that haven't been written to in a while. When purging by ctime (existing behavior) we can purge a log that was created a long time ago but is still being written to today (e.g., due to low log volume).
There is also a bugfix for the existing test. Not sure it happens in real life but it affected the test.