Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtgate: export routing_rules in /debug/vschema #4899

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

sougou
Copy link
Contributor

@sougou sougou commented Jun 1, 2019

Signed-off-by: Sugu Sougoumarane ssougou@gmail.com

@sougou sougou requested a review from deepthi June 1, 2019 23:37
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you can merge after fixing the typo.

executor.ServeHTTP(resp, req)
v := make(map[string]interface{})
if err := json.Unmarshal(resp.Body.Bytes(), &v); err != nil {
t.Fatalf("Unmarhsal on %s failed: %v", resp.Body.String(), err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo - Unmarshal

Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
@sougou sougou merged commit ea85d29 into vitessio:master Jun 6, 2019
@sougou sougou deleted the ss-vschema branch June 11, 2019 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants