Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtgate plan: auto-expand insert column list #4900

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

sougou
Copy link
Contributor

@sougou sougou commented Jun 1, 2019

If the table has authoritative column list, use it to auto-expand
insert columns if they were not supplied.

Signed-off-by: Sugu Sougoumarane ssougou@gmail.com

If the table has authoritative column list, use it to auto-expand
insert columns if they were not supplied.

Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
@sougou sougou requested a review from deepthi June 6, 2019 19:54
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. +1 for unit test.

@deepthi deepthi merged commit 22dbada into vitessio:master Jun 11, 2019
@sougou sougou deleted the ss-expand-insert branch June 14, 2019 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants