Reorder keyspace ids when reordering bulk lookup table inserts. #4919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise bulk `insert ignore` queries will fail as the validate assumes the values and ids are still in the same order. Signed-off-by: Michael Pawliszyn <mikepaw@squareup.com>
|
Thanks to @eeSeeGee for figuring the bug out. |
|
This bug only manifests when you have A) INSERT IGNORE B) A lookup C) Multiple rows |
sougou
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise bulk
insert ignorequeries will fail as the validate assumesthe values and ids are still in the same order.
Signed-off-by: Michael Pawliszyn mikepaw@squareup.com