vreplication: code improvement #4946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning queries to execute is a bad pattern, and bloats code. This new pattern delegates the generation and execution to a single function. Much cleaner code. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Push down the retriable exec into vdbClient so vcopier can also use it. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
deepthi
approved these changes
Jun 24, 2019
| } | ||
| continue | ||
| } | ||
| if _, err := vc.DBClient.ExecuteFetch(q, 10000); err != nil { | ||
| return err | ||
| result, err := vc.DBClient.ExecuteFetch(q, 100000) |
There was a problem hiding this comment.
Since this is using the default maxRows, can you replace it with a call to Execute?
There was a problem hiding this comment.
This was set to 100K rows based on the max packet size of 30K. There's actually no need to set a limit on number of rows because it can't exceed the max packet size. However, since max packet size is configurable, I think I should set it to max packet size itself (assuming worst case of 1 byte per row).
There was a problem hiding this comment.
Ah, this is being passed down to DBClient. That sounds like a good idea.
There was a problem hiding this comment.
As for maxrows in the original ExecuteFetch, the signature cannot be changed until old binlog player is deprecated.
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning queries to execute is a bad pattern, and bloats code.
This new pattern delegates the generation and execution to a
single function. Much cleaner code.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com