Support deleting multiple tables and wildcards #4949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sougou
reviewed
Jun 24, 2019
unsharded keyspaces Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
saifalharthi
force-pushed
the
sa-support-wildcard
branch
from
6a3c99a
to
3aa9e52
Compare
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
sougou
approved these changes
Jul 3, 2019
| @@ -2062,6 +2076,12 @@ table_name: | |||
| $$ = TableName{Qualifier: $1, Name: $3} | |||
| } | |||
|
|
|||
| delete_table_name: | |||
There was a problem hiding this comment.
This wouldn't allow a construct like delete a, b.* from.... However, I think it's ok because we've already gone above and beyond on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #4947
Added small modification to the parser and added parser test. Will add end to end test to check if its working properly