Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local docker development #4951

Merged
merged 42 commits into from
Jul 20, 2019
Merged

Local docker development #4951

merged 42 commits into from
Jul 20, 2019

Conversation

jawabuu
Copy link
Contributor

@jawabuu jawabuu commented Jun 25, 2019

Provide a seamless, predictable and consistent development environment for beginners to test out vitess locally.
The compose example was chosen to begin with because it is able to run with minimal resources.
The example has also been updated to allow vitess to run with an external mysql instance.

@jawabuu
Change compose version to 2.3
065da75 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
Create healthcheck for vttablet1
09c446b 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
add healtcheck to start vtgate only when vttablet is healthy
05ae88a 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
add environment variables to enable vitess with external mysql server
5fbf896 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
add environment variables to compose file
2d21c0f 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
create local dbname and external variables
1bcd493 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
add logic to create rdonly tablets
51971f4 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
use common init_db file to create database users
94bc052 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
create database and users when mysql instance is external
54bf7d6 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
update mysql cnf loaded by vitess
1aebbff 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
export external db variables
09f0667 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
restrict mysql creation when master is not external
2a2a7c1 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
set conditional flags for external db
d7c5e9e 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
update start vttablet args
790b1e8 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
add db charset variable
412e4e2 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
add fix replication script for external mysql databases
6e491dc 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
add depends on to ensure master starts first
c83803a 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
enable ltvtcl.sh to work in windows git bash
b6ea5b4 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
only check status if status argument is passed
8081919 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
add mysql client helper script that uses mysql present in containers
fba164e 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
add fix replication helper script
4f9ec17 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
update readme with advanced usage examples
8a45f17 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
Add documentation on helper scripts
ee8ad1a 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
Merge branch 'master' into local-docker-development
f51ca1a
@jawabuu
update client script use docker-compose exec
efe0660 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
update readme documentation
f6df144 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu jawabuu requested a review from sougou as a code owner June 25, 2019 15:39
@sougou sougou requested a review from dkhenry June 25, 2019 17:39
@jawabuu
fix formatting in readme
45c4263 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
add warning to secure connection to external database
f6fe82b 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
Merge branch 'master' into local-docker-development
ab71087
@jawabuu
update instructions to use SetReadWrite instead of mysql query if mas…
3ee0004 
…ter starts as readonly

Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
Copy link
Contributor Author

jawabuu commented Jun 27, 2019

@dkhenry Here's the pull request for the compose example for your review.

dkhenry
dkhenry suggested changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@dkhenry dkhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jawabuu This all looks good, one change I need is all the Copyright 2018 GitHub Inc. need to be Copyright 2019 Vitess Authors.

Everything looks good I am going to try it out now and see if it works for me

@jawabuu
Copy link
Contributor Author

jawabuu commented Jun 28, 2019

@dkhenry Excellent, standing by. Let me know how it goes.

@jawabuu
update copyright text to Vitess Authors
1f320d9 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
Merge branch 'master' into local-docker-development
8c01085
@jawabuu
update copyright text to The Vitess Authors
e858116 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
Copy link
Contributor Author

jawabuu commented Jun 28, 2019

@sougou Updated.

@jawabuu
enable backup and restore functionality
688001a 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
add and mount backups directory
e19a89d 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
use ips for tablet hostnames to simplify testing in docker
68fc3d1 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
configure schema reload every 60 seconds
88f10ac 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
set ReadWrite on master on first run of vtgate //TODO use hooks
43f75dc 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
Merge branch 'master' into local-docker-development
81c7281
@jawabuu
remove stray square brackets in script
46156c0 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
@jawabuu
Merge branch 'master' into local-docker-development
3089630
@jawabuu
minor formatting changes
44f3a76 
Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com>
dkhenry
dkhenry approved these changes Jul 20, 2019
View reviewed changes
Copy link
Contributor

@dkhenry dkhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay this all looks good to me 👍

@dkhenry dkhenry merged commit 2fe5d9f into vitessio:master Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhenry dkhenry dkhenry approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jawabuu @dkhenry @sougou