Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial support for capabilities #4987

Merged
merged 19 commits into from
Aug 8, 2019
Merged

Add initial support for capabilities #4987

merged 19 commits into from
Aug 8, 2019

Commits on Jul 10, 2019

  1. Add initial support for capabilities 

    This eliminates the need to set MYSQL_FLAVOR

Signed-off-by: Morgan Tocker <tocker@gmail.com>
    @morgo
    morgo committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    f336afe View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2019

  1. Removed MYSQL_FLAVOR variable precedence 

    It will cause backwards compatibility problems,
since many users set "MySQL56" for any MySQL system.

Signed-off-by: Morgan Tocker <tocker@gmail.com>
    @morgo
    morgo committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    030c2fd View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2019

  1. Address PR feedback (WIP) 

    Signed-off-by: Morgan Tocker <tocker@gmail.com>
    @morgo
    morgo committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    118f3e7 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2019

  1. Merge remote-tracking branch 'upstream/master' into morgo-mysql-capab… 

    …ilities

Signed-off-by: Morgan Tocker <tocker@gmail.com>
    @morgo
    morgo committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    a8343f9 View commit details
    Browse the repository at this point in the history

  2. Fixed mysql_safe to not use capabilitities 

    Reverted small changes to configs

Signed-off-by: Morgan Tocker <tocker@gmail.com>
    @morgo
    morgo committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    469a94e View commit details
    Browse the repository at this point in the history

  3. fix version detection 

    Signed-off-by: Morgan Tocker <tocker@gmail.com>
    @morgo
    morgo committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    cd47164 View commit details
    Browse the repository at this point in the history

  4. Fix style, re-add EXTRA_MY_CNF from review 

    Signed-off-by: Morgan Tocker <tocker@gmail.com>
    @morgo
    morgo committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    e1ff1b7 View commit details
    Browse the repository at this point in the history

  5. Address review feedback 

    Signed-off-by: Morgan Tocker <tocker@gmail.com>
    @morgo
    morgo committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    ed86bd5 View commit details
    Browse the repository at this point in the history

  6. address remaining feedback 

    Signed-off-by: Morgan Tocker <tocker@gmail.com>
    @morgo
    morgo committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    79dbc8e View commit details
    Browse the repository at this point in the history

  7. Remove rogue added space 

    Signed-off-by: Morgan Tocker <tocker@gmail.com>
    @morgo
    morgo committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    a02bbad View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2019

  1. Address PR feedback 

    Signed-off-by: Morgan Tocker <tocker@gmail.com>
    @morgo
    morgo committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    5339cbb View commit details
    Browse the repository at this point in the history

  2. Address PR feedback 

    Signed-off-by: Morgan Tocker <tocker@gmail.com>
    @morgo
    morgo committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    f881735 View commit details
    Browse the repository at this point in the history

  3. Fix broken test 

    Signed-off-by: Morgan Tocker <tocker@gmail.com>
    @morgo
    morgo committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    2fde7d4 View commit details
    Browse the repository at this point in the history

  4. Fixed tests 

    Signed-off-by: Morgan Tocker <tocker@gmail.com>
    @morgo
    morgo committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    555f559 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2019

  1. Addressed PR feedback 

    Added tests for version detection

Signed-off-by: Morgan Tocker <tocker@gmail.com>
    @morgo
    morgo committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    e7f7474 View commit details
    Browse the repository at this point in the history

  2. update copyright 

    Signed-off-by: Morgan Tocker <tocker@gmail.com>
    @morgo
    morgo committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    1ecd822 View commit details
    Browse the repository at this point in the history

  3. Remove unset MYSQL_FLAVOR 

    I thought about this: it's a bad idea.
It means that if there was a test that created 2 mysqld's, the usage
would not be repeatable/idempotent.

Signed-off-by: Morgan Tocker <tocker@gmail.com>
    @morgo
    morgo committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    d4ca143 View commit details
    Browse the repository at this point in the history

  4. Make sure error is caught. 

    Signed-off-by: Morgan Tocker <tocker@gmail.com>
    @morgo
    morgo committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    e4b487b View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. Address PR Feedback 

    Signed-off-by: Morgan Tocker <tocker@gmail.com>
    @morgo
    morgo committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    bc08f6a View commit details
    Browse the repository at this point in the history