vreplication: bug fixes #5012
Merged
vreplication: bug fixes #5012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The catchup code path was ignoring lastpk for wildcard expressions in the filter. This is now fixed. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
The vcopier was using a timer instead of a ticker in its wait loop which caused it to wait forever even if the replication had caught up. The change includes a new test that tests the full copy cycle and ensures that multiple iterations succeed. A similar incorrect usage was found in logutil. That's also been fixed. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs found during production testing:
vreplication: handle copy for wildcards
The catchup code path was ignoring lastpk for wildcard expressions in the filter. This is now fixed.
vcopier: use ticker instead of timer
The vcopier was using a timer instead of a ticker in its wait loop which caused it to wait forever even if the replication had caught up.
The change includes a new test that tests the full copy cycle and ensures that multiple iterations succeed.
A similar incorrect usage was found in logutil. That's also been fixed.