Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Prepared Statements #5018

Merged
merged 43 commits into from
Aug 9, 2019
Merged

Add Support for Prepared Statements #5018

merged 43 commits into from
Aug 9, 2019

Conversation

saifalharthi
Copy link
Contributor

@saifalharthi saifalharthi commented Jul 24, 2019 •
edited by deepthi
Loading

This is a continuation for #3862.

Added unit tests and end to end tests to ensure that Prepared statements is working properly.

cc: @dcadevil @Johnny-Three

dcadevil and others added 28 commits January 15, 2019 18:49
@dcadevil
support for the ComPrepare
30cda05 
Signed-off-by: dcadevil <dcadevil@126.com>
@dcadevil
support for the MySQL prepare command protocol
91f73b1 
Signed-off-by: dcadevil <dcadevil@126.com>
@dcadevil
add missing function implementation
85f6d74 
Signed-off-by: dcadevil <dcadevil@126.com>
@dcadevil
delete unused code
6024566 
Signed-off-by: dcadevil <dcadevil@126.com>
@dcadevil
add missing function implementation
25d1643 
Signed-off-by: dcadevil <dcadevil@126.com>
@dcadevil
add missing function implementation
9f0e7c3 
Signed-off-by: dcadevil <dcadevil@126.com>
@dcadevil
add comments
24d0dd0 
Signed-off-by: dcadevil <dcadevil@126.com>
@dcadevil
Merge branch 'master' into prepare
2393ff7
@deepthi
Merge branch 'prepare' of git://github.com/tiglabs/vitess into tiglab…
ed00790 
…s-prepare

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
fix compile errors after merge
82c5e90 
Signed-off-by: deepthi <deepthi@planetscale.com>
@saifalharthi
Merge remote-tracking branch 'origin/master' into tiglabs-prepare
24ea99f 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Merge remote-tracking branch 'origin/master' into tiglabs-prepare
9ceb1f4 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Merge remote-tracking branch 'origin/master' into tiglabs-prepare
e523677 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Added test for ComPrepare
8d641ee 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
added few more tests in query_test
96ed068 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Merge remote-tracking branch 'origin/master' into tiglabs-prepare
70096dd 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Added executor tests. They are faulty now.
1470f76 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Added python end to end test
698243b 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Fix error message
0d39607 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Added test for TestComStmtExecute
bc1ac07 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Merge remote-tracking branch 'origin/master' into tiglabs-prepare
b72f38b 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Add Executor test for DML
d278419 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Added Excutor test for select
69729e9 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Added Executor test for select
a51fabc 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Merge branch 'tiglabs-prepare' of github.com:planetscale/vitess into …
387cb98 
…tiglabs-prepare

Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Added mysql-connector dependency
ed69725 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Added dependency to bootstrap.sh and edited python test
c55be51 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Updated TestComPrepare test
85a4f18 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Replaced etcd2 with zk for end to end tests
6a01fe0 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Set correct value for topo-server
611820a 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Fix TestTypeError
786f7d8 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Edit utils.py
04c1100 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@derekperkins
Copy link
Member

We could definitely use support for prepared statements

sougou
sougou reviewed Jul 28, 2019
View reviewed changes
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent piece of work! I only have a few nit-picks.

go/mysql/conn.go Show resolved Hide resolved
go/mysql/conn.go Outdated Show resolved Hide resolved
go/mysql/query.go Outdated Show resolved Hide resolved
go/mysql/conn.go Show resolved Hide resolved
go/mysql/conn.go Outdated Show resolved Hide resolved
go/mysql/conn.go Outdated Show resolved Hide resolved
go/vt/vtgate/executor.go Outdated Show resolved Hide resolved
go/vt/vtgate/executor.go Outdated Show resolved Hide resolved
go/vt/vtgate/executor.go Outdated Show resolved Hide resolved
go/vt/vtgate/vtgate.go Outdated Show resolved Hide resolved
@saifalharthi
Addressed partial comments
5eb5830 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Quick fix
017cf57 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
deepthi
deepthi reviewed Aug 1, 2019
View reviewed changes
test/prepared_statement_test.py Outdated Show resolved Hide resolved
test/prepared_statement_test.py Outdated Show resolved Hide resolved
@saifalharthi
Document test
03217bd 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Merge remote-tracking branch 'origin/master' into tiglabs-prepare
a138a40 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
sougou
sougou reviewed Aug 5, 2019
View reviewed changes
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more comments.

go/mysql/conn.go Outdated Show resolved Hide resolved
go/vt/vtgate/executor.go Outdated Show resolved Hide resolved
go/mysql/conn.go Outdated Show resolved Hide resolved
@saifalharthi
Fix Tests
0fedf79 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Merge remote-tracking branch 'origin/master' into tiglabs-prepare
3dc1bf5 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Fix mount path
3f67a4a 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Merge remote-tracking branch 'origin/master' into tiglabs-prepare
d7fb060 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Fixed tests and bug in ComPrepare
58a810f 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
sougou
sougou reviewed Aug 9, 2019
View reviewed changes
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to approve, but found a potential bug. Can you write a test for it?
Make sure it fails, and then make sure the fix fixes the problem.

go/mysql/conn.go Outdated Show resolved Hide resolved
go/mysql/conn.go Outdated Show resolved Hide resolved
go/mysql/conn.go Show resolved Hide resolved
sougou
sougou reviewed Aug 9, 2019
View reviewed changes
go/mysql/conn.go Outdated Show resolved Hide resolved
@saifalharthi
Address comments
d90e723 
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
@saifalharthi
Added end to end test fail ComPrepare and make sure other queries do …
112187e 
…not get affacted

Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
sougou
sougou approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally!

@sougou sougou merged commit 95f1642 into vitessio:master Aug 9, 2019
@derekperkins derekperkins mentioned this pull request Oct 1, 2019
Closed
@deepthi deepthi deleted the tiglabs-prepare branch July 6, 2020 19:02
systay pushed a commit that referenced this pull request Jul 22, 2024
@planetscale-actions-bot
cherry pick of 15760 (#5018)
ad18660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi left review comments

@sougou sougou sougou approved these changes

@derekperkins derekperkins Awaiting requested review from derekperkins

@dkhenry dkhenry Awaiting requested review from dkhenry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saifalharthi @derekperkins @deepthi @sougou @dcadevil