Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: expose VT_EXTRA_BUILD_FLAGS for use of external build systems #5022

Merged
merged 1 commit into from
Jul 28, 2019
Merged

Makefile: expose VT_EXTRA_BUILD_FLAGS for use of external build systems #5022

merged 1 commit into from
Jul 28, 2019

Conversation

acharis
Copy link
Contributor

@acharis acharis commented Jul 25, 2019

example:
VT_EXTRA_BUILD_FLAGS='-gcflags="-N -l"'

@deepthi

Signed-off-by: Alex Charis acharis@hubspot.com

Makefile: expose VT_EXTRA_BUILD_FLAGS for use of external build systems
d0400ff 
Signed-off-by: Alex Charis <acharis@hubspot.com>
@acharis acharis requested a review from sougou as a code owner July 25, 2019 21:46
@deepthi deepthi requested a review from dkhenry July 25, 2019 22:16
sougou
sougou approved these changes Jul 28, 2019
View reviewed changes
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks harmless enough.

@sougou sougou merged commit d5bf8ce into vitessio:master Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou sougou approved these changes

@dkhenry dkhenry Awaiting requested review from dkhenry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acharis @sougou