Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: vitess/k8s: Include all my.cnf template files. #5068

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

enisoc
Copy link
Member

@enisoc enisoc commented Aug 9, 2019

There are now a larger set of required templates (since #4987) because we have auto-included files for every minor version (e.g. 5.6 vs 5.7). Just include everything instead of trying to pick and choose.

Signed-off-by: Anthony Yeh enisoc@planetscale.com

There are now a larger set of required templates because we have
auto-included files for every minor version (e.g. 5.6 vs 5.7).
Just include everything instead of trying to pick and choose.

Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Can merge after CI passes.

@enisoc enisoc merged commit edc2a24 into vitessio:master Aug 9, 2019
@enisoc enisoc deleted the docker-mycnf branch August 9, 2019 06:04
morgo pushed a commit to planetscale/vitess that referenced this pull request Aug 9, 2019
There are now a larger set of required templates because we have
auto-included files for every minor version (e.g. 5.6 vs 5.7).
Just include everything instead of trying to pick and choose.

Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants