Move git hooks to start of bootstrap #5091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
sougou
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change to the bootstrap. I moved creating git hooks to the start, and they are not gated by
BUILD_TESTS.The motivation for doing this, is that I was doing something naive (and have to assume others are doing this too): the selenium dependency forces the rest of the script to fail. I manually ran the
govendorandgo getsteps that followed (because I had to), but did not run the git hook code.In the future we will remove the selenium requirement (and I think later we can remove the
govendor/go getvia go modules), but until then this is hopefully an improvement.Edit: some dead code is also removed about number of cores. It is not used anywhere.
Signed-off-by: Morgan Tocker tocker@gmail.com