Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup from capabilities PR #5105

Merged
merged 4 commits into from
Aug 17, 2019

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Aug 16, 2019

This cleans up some small issues with capabilities, introduced in #4987

It modifies the bootstrap, which the CI system can not accurately test. Here is the proof that it runs without impact to the image:

$ make docker_bootstrap && make docker_test flavor=mysql57
..
2019/08/16 22:00:11 mysql57.unit_race                           FLAKY (1/2 failed)
2019/08/16 22:00:11 mysql57.update_stream                       PASS
2019/08/16 22:00:11 mysql57.update_stream_rbr                   PASS
2019/08/16 22:00:11 mysql57.vertical_split                      PASS
2019/08/16 22:00:11 mysql57.vertical_split_rbr                  PASS
2019/08/16 22:00:11 mysql57.vschema                             PASS
2019/08/16 22:00:11 mysql57.vtctld                              PASS
2019/08/16 22:00:11 mysql57.vtctld_web                          PASS
2019/08/16 22:00:11 mysql57.vtgate_buffer                       PASS
2019/08/16 22:00:11 mysql57.vtgate_utils                        PASS
2019/08/16 22:00:11 mysql57.vtgatev2                            PASS
2019/08/16 22:00:11 mysql57.vtgatev3                            PASS
2019/08/16 22:00:11 mysql57.vttest_sample                       PASS
2019/08/16 22:00:11 mysql57.worker                              PASS
2019/08/16 22:00:11 mysql57.xtrabackup                          PASS
2019/08/16 22:00:11 mysql57.xtrabackup_xbstream                 PASS
2019/08/16 22:00:11 ============================================================
2019/08/16 22:00:11 53 PASSED, 1 FLAKY, 0 FAILED, 0 SKIPPED
2019/08/16 22:00:11 Total time: 2h1m43.2s

Signed-off-by: Morgan Tocker tocker@gmail.com

Signed-off-by: Morgan Tocker <tocker@gmail.com>
…pabilities

Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
@morgo morgo marked this pull request as ready for review August 17, 2019 04:01
@morgo morgo requested a review from sougou as a code owner August 17, 2019 04:01
@sougou sougou merged commit 8d852ef into vitessio:master Aug 17, 2019
@morgo morgo deleted the morgo-followup-capabilities branch August 17, 2019 18:58
systay pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants