Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

routing rules: handle corner case in delete #5111

Merged
merged 1 commit into from
Aug 22, 2019
Merged

routing rules: handle corner case in delete #5111

merged 1 commit into from
Aug 22, 2019

Conversation

sougou
Copy link
Contributor

@sougou sougou commented Aug 19, 2019

Signed-off-by: Sugu Sougoumarane ssougou@gmail.com

@sougou
routing rules: handle corner case in delete
30d6e0d 
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
@sougou sougou requested a review from dkhenry August 19, 2019 04:32
deepthi
deepthi approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deepthi deepthi merged commit 98a735d into vitessio:master Aug 22, 2019
@sougou sougou deleted the ss-vrepl-work branch August 24, 2019 19:22
systay pushed a commit that referenced this pull request Jul 22, 2024
@planetscale-actions-bot
cherry pick of 15853 (#5111)
c61a2c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@dkhenry dkhenry Awaiting requested review from dkhenry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sougou @deepthi