Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make TabletExternallyReparented more robust #5151

Merged
merged 8 commits into from
Sep 13, 2019
Merged

make TabletExternallyReparented more robust #5151

merged 8 commits into from
Sep 13, 2019

Commits on Sep 9, 2019

  1. along with old master also update any other tablet that thinks it is … 

    …master to REPLICA

Signed-off-by: deepthi <deepthi@planetscale.com>
    @deepthi
    deepthi committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    a65a7f6 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2019

  1. address review comments 

    Signed-off-by: deepthi <deepthi@planetscale.com>
    @deepthi
    deepthi committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    7bd6618 View commit details
    Browse the repository at this point in the history

  2. check tablet is really master before changing type, add unit test 

    Signed-off-by: deepthi <deepthi@planetscale.com>
    @deepthi
    deepthi committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    2b718e9 View commit details
    Browse the repository at this point in the history

  3. fix race condition, one more unit test 

    Signed-off-by: deepthi <deepthi@planetscale.com>
    @deepthi
    deepthi committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    8236bdb View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2019

  1. make TER idempotent so that it can be called again if the first call … 

    …does not complete all steps

Signed-off-by: deepthi <deepthi@planetscale.com>
    @deepthi
    deepthi committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    ccba3db View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2019

  1. add comments explaining why some synchronization has been removed 

    Signed-off-by: deepthi <deepthi@planetscale.com>
    @deepthi
    deepthi committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    5515740 View commit details
    Browse the repository at this point in the history

  2. fix/add descriptive comments, avoid unnecessary topo calls, merge 2 l… 

    …oops into 1 and remove use of channel that is no longer needed

Signed-off-by: deepthi <deepthi@planetscale.com>
    @deepthi
    deepthi committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    6b2d0d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2019

  1. defer event update, only make a copy of tablet if we are changing it,… 

    … use one tmc for all calls to RefreshState

Signed-off-by: deepthi <deepthi@planetscale.com>
    @deepthi
    deepthi committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    90d3b8a View commit details
    Browse the repository at this point in the history