Prevent log purging of symlinks #5154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sougou
reviewed
Sep 5, 2019
go/vt/logutil/purge.go
Outdated
| for _, level := range levels { | ||
| c, err := filepath.EvalSymlinks(path.Join(dir, fmt.Sprintf("%s.%s", program, level))) | ||
| symPath := path.Join(dir, fmt.Sprintf("%s.%s", program, level)) | ||
| hardPath, err := filepath.EvalSymlinks(symPath) |
There was a problem hiding this comment.
This example from the os package may be a more reliable way to test for symlink: https://play.golang.org/p/VHdX7KlARqI. In fact, you should probably do check for a mode.IsRegular(), which will take care of other weird things like directory, etc.
Signed-off-by: Adam Saponara <as@php.net>
adsr
force-pushed
the
prevent-purge-symlink
branch
from
5d5f142
to
e7f3ef8
Compare
sougou
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents purging of current log files, i.e., logs that are pointed to by a symlink such as
vttablet.INFO. Previously we were allowed to delete the current log file if the underlying log file was low volume and had an mtime that put it beyond the retention period.Signed-off-by: Adam Saponara as@php.net