migrater: identify shard migration differently #5178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we identifid a migration as SHARD of the source and target keyspaces matched. But it's possible to have table migrations within a keyspace. This new way identifies a migration as SHARD only if the source and target shards don't match. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
| @@ -902,34 +902,6 @@ func TestMigrateNoTableWildcards(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestShardMigrateTargetMatchesSource(t *testing.T) { | |||
There was a problem hiding this comment.
There is no way of testing it?
There was a problem hiding this comment.
the test was for the error message, which is no longer being produced.
There was a problem hiding this comment.
I meant in general. The whole test was deleted and nothing was added.
There was a problem hiding this comment.
I remember why I didn't add a test. It's more relevant to add one when we add the shard validation (the TODO that I added). But this change is a pre-req for the other changes I have lined up.
deepthi
reviewed
Sep 10, 2019
| @@ -239,7 +239,16 @@ func (wr *Wrangler) buildMigrater(ctx context.Context, targetKeyspace, workflow | |||
| if mi.sourceKeyspace != mi.targetKeyspace { | |||
| mi.migrationType = binlogdatapb.MigrationType_TABLES | |||
| } else { | |||
| // TODO(sougou): for shard migration, validate that source and target combined | |||
There was a problem hiding this comment.
is this in a forthcoming PR? wondering why a TODO rather than implement it in this one.
There was a problem hiding this comment.
Yeah. I've added it to the list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we identifid a migration as SHARD of the source and
target keyspaces matched. But it's possible to have table migrations
within a keyspace.
This new way identifies a migration as SHARD only if the source and
target shards don't match.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com