Allow sending back stale shard name data if requested,… #5189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @aquarapid! We tend to not list the issue in the PR title, preferring a line like |
|
Need to fix DCO. Also, the build broke. Looks like some interfaces may need to be updated. |
|
@aquarapid ping |
…uested, instead of zeroing it out. Signed-off-by: Jacques Grove <aquarapid@gmail.com>
aquarapid
force-pushed
the
jacques_issue5038
branch
from
5f444a2 to
d61f87f
Compare
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
aquarapid
force-pushed
the
jacques_issue5038
branch
from
068f367 to
bad7398
Compare
deepthi
changed the title
while the topo cache is refreshing. Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
server refresh period after TTL expires * Add tests Signed-off-by: Jacques Grove <aquarapid@gmail.com>
|
@deepthi @sougou this is ready for review. As a stress test, I ran the script mentioned here #5038 (comment) but with a million iterations against a vtgate instance, and did not see a single error. |
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
deepthi
approved these changes
May 1, 2020
|
Trying to kick CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… instead of zeroing it out.
Fixes #5038