Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invocation of deferred function for loading schema. #5271

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Fix invocation of deferred function for loading schema. #5271

merged 1 commit into from
Oct 11, 2019

Commits on Oct 8, 2019

  1. Fix invocation of deferred function for loading schema. 

    Golang's defer's arguments are evaluated immediately. Thus the time.Since(start) was being resolved immediately, rather than at the end of function execution.

Signed-off-by: dleibovic <dleibovic@etsy.com>
    @dasl-
    dasl- committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    a851d7b View commit details
    Browse the repository at this point in the history