Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SetMaster idempotent. #5300

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Conversation

enisoc
Copy link
Member

@enisoc enisoc commented Oct 14, 2019

NOTE: This PR is targeting the reparent-refactor feature branch, not master.

Signed-off-by: Anthony Yeh enisoc@planetscale.com

@enisoc enisoc requested a review from deepthi October 14, 2019 22:20
@enisoc enisoc requested a review from sougou as a code owner October 14, 2019 22:20
@enisoc enisoc force-pushed the set-master branch 2 times, most recently from 230da69 to a90f6d9 Compare October 14, 2019 23:32
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The comments were really helpful in understanding the changes.

@deepthi
Copy link
Member

deepthi commented Oct 15, 2019

Test failures look legit, they will need to be resolved before merging.

Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
@enisoc enisoc force-pushed the set-master branch 2 times, most recently from 31e6854 to 9a7d12c Compare October 15, 2019 21:56
@enisoc enisoc merged commit 1bab089 into vitessio:reparent-refactor Oct 15, 2019
@enisoc enisoc deleted the set-master branch October 15, 2019 23:07
systay pushed a commit that referenced this pull request Jul 22, 2024
systay pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants