Don't set RestorePosition in local_metadata. #5379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This temporarily stops setting the RestorePosition in local_metadata because the table's value column is not big enough to fit typical replication positions, and therefore tablets are blocked from restoring. We plan to re-enable RestorePosition after altering the local_metadata table to make the value column big enough. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
|
This is currently breaking us, so I'd like to get this merged ASAP |
derekperkins
approved these changes
Oct 30, 2019
deepthi
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This temporarily stops setting the RestorePosition in local_metadata
because the table's value column is not big enough to fit typical
replication positions, and therefore tablets are blocked from restoring.
We plan to re-enable RestorePosition after altering the local_metadata
table to make the value column big enough.
This is a temporary mitigation for #5377.
Signed-off-by: Anthony Yeh enisoc@planetscale.com