Don't recheck mysqld port if it was provided explicitly. #5383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At startup, we already avoid asking mysqld for its port if we were given the port in DB configs. However, we would forget this port when we later trigger a recheck of the MySQL port. It's important to trust the port that was given to us because it might be different from the port that mysqld is actually serving on, such as in the case that the host we were given is actually a proxy. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
deepthi
approved these changes
Nov 5, 2019
systay
pushed a commit
that referenced
this pull request
Jul 22, 2024
…5383) * cherry pick of 15797 * Extend unit race test timeout too Signed-off-by: Matt Lord <mattalord@gmail.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At startup, we already avoid asking mysqld for its port if we were given
the port in DB configs. However, we would forget this port when we later
trigger a recheck of the MySQL port.
It's important to trust the port that was given to us because it might
be different from the port that mysqld is actually serving on, such as
in the case that the host we were given is actually a proxy.
Signed-off-by: Anthony Yeh enisoc@planetscale.com