VerticalSplitClone no longer supports -min_rdonly_healthy_tablets #5433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you fix the DCO? The Details link will tell you what to do. |
|
@chrisrgithub We can't approve this until the DCO is addressed. |
…lows -min_rdonly_tablets Signed-off-by: ChrisR <radsurfer@gmail.com>
chrisrgithub
force-pushed
the
helm-example-fix
branch
from
6db4a1a
to
20be237
Compare
|
I believe this file has been added to the wrong place. It should be a change to the existing file of that name in examples/helm. |
|
I have modified this branch locally to correct the file placement. Will confer with Deepthi on how to re-apply and modify or restart this PR. |
|
Deepthi states that this PR will get updated correctly, and it appears so. |
…lows -min_rdonly_tablets (with corrected file location) Signed-off-by: ChrisR <radsurfer@gmail.com>
chrisrgithub
force-pushed
the
helm-example-fix
branch
from
fe1e4bf
to
4a111dc
Compare
systay
pushed a commit
that referenced
this pull request
Jul 22, 2024
* Vitess tester workflow (#16127) Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix test summary in workflow Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: regenerate CI Signed-off-by: Manan Gupta <manan@planetscale.com> --------- Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com> Co-authored-by: Manan Gupta <manan@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...but still allows -min_rdonly_tablets. Changed it to that.