Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: Prepared Statements Bind Variables Nil Error #5441

Merged
merged 5 commits into from
Nov 22, 2019
Merged

Bug Fix: Prepared Statements Bind Variables Nil Error #5441

merged 5 commits into from
Nov 22, 2019

Commits on Nov 15, 2019

  1. Fixed nil bind variables error by resetting bindvars to an empty map.… 

    … Also added a recover to catch panics that occur inside Logf due to FormatBindVariables call potentially panicking.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic
    PrismaPhonic committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    e83a02c View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2019

  1. Changed import order back. Order was auto-changed by IDE on save 

    Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic
    PrismaPhonic committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    bb7f9fb View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2019

  1. Using stored ParamsCount for capacity per review suggestion. 

    Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic
    PrismaPhonic committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    0da79a8 View commit details
    Browse the repository at this point in the history

  2. Added explanation comment per review suggestion. 

    Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic
    PrismaPhonic committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    4411cda View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2019

  1. Removed explicit panic after offline talk with sougou and deepthi 

    Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic
    PrismaPhonic committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    c4270d2 View commit details
    Browse the repository at this point in the history