Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vitessdriver.Open example #5552

Merged
merged 1 commit into from
Dec 12, 2019

Conversation

teejae
Copy link
Contributor

@teejae teejae commented Dec 12, 2019

Current docs are out of date and do not match the signature of vitessdriver.Open.

@teejae teejae requested a review from sougou as a code owner December 12, 2019 06:44
Copy link
Member

@enisoc enisoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Toliver Jue <toliver@planetscale.com>
@teejae
Copy link
Contributor Author

teejae commented Dec 12, 2019

Not sure why the unit/Build fails.

@morgo
Copy link
Contributor

morgo commented Dec 12, 2019

Not sure why the unit/Build fails.

Fetched 52.4 MB in 2s (26.4 MB/s)
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/p/pulseaudio/libpulse0_11.1-1ubuntu7.2_amd64.deb  404  Not Found [IP: 52.177.174.250 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
##[error]Process completed with exit code 100.

Unit failed in fetching dependencies. We don't run apt-get update currently, and assume it is up to date. It looks like it wasn't, since the package has been removed (i.e. there was probably a security update). This is the first time I have seen this happen, but if it's frequent we can add an apt-get update to the script.

@enisoc enisoc merged commit aea1dcf into vitessio:master Dec 12, 2019
@enisoc enisoc deleted the tj-vitessdriver-open-doc branch December 12, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants