-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vttablet-up.sh : Adds detection of mysqld launch failure. #5573
Conversation
I think we should try and embed this check in mysqlctl itself. Otherwise, users who don't use our examples won't benefit. |
…re, tests for further for presence of apparmor. Exits with error and recommendation to disable. Signed-off-by: ChrisR <radsurfer@gmail.com>
30af3a2
to
fa2d86b
Compare
Good point, but worth doing in the example until that is implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
examples/local/vttablet-up.sh
Outdated
err=$? | ||
if [[ $err -ne 0 ]]; then | ||
echo "Checking for apparmor status for mysqld:" | ||
sudo aa-status | grep mysqld |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stock Ubuntu will pause and wait for a password here. It is only cloud instances that have sudo no password configured. We should instead recommend running this command to check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is right.. @chrisrgithub you will need to remove this check but still print a helpful message.
examples/local/vttablet-up.sh
Outdated
function fail() { | ||
echo "ERROR: $1" | ||
exit 1 | ||
} | ||
|
||
# Travis hostnames are too long for MySQL, so we use IP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function should already be present, because it is in env.sh
…n info. Signed-off-by: ChrisR <radsurfer@gmail.com>
|
Given failure, tests for further for presence of apparmor. Exits with error and recommendation to disable.