vrepl: misc cleanup #5594
Merged
vrepl: misc cleanup #5594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepthi
reviewed
Dec 19, 2019
| @@ -116,8 +108,12 @@ func (plan *Plan) filter(values []sqltypes.Value) (bool, []sqltypes.Value, error | |||
| return true, result, nil | |||
| } | |||
|
|
|||
| func getKeyspaceID(values []sqltypes.Value, vindex vindexes.Vindex) (key.DestinationKeyspaceID, error) { | |||
| destinations, err := vindexes.Map(vindex, nil, [][]sqltypes.Value{values}) | |||
| func getKeyspaceID(values []sqltypes.Value, vindex vindexes.Vindex, vindexColumns []int) (key.DestinationKeyspaceID, error) { | |||
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
The vstreamer API changes used by MySQLVStreamerClient raised some lint errors. The new APIs export a more clean one which don't raise any linter alarms. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
The function was returning a match if a regexp failed. It now treats it as no match. This code appears to be unreachable because there is a higher level function that checks for regexp errors. This is just a conservative change to prevent future bugs. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
sougou
force-pushed
the
ss-vrepl-misc
branch
from
576d46d
to
f8fa12d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some misc cleanup before the Migrate command implementation.