tests: deflake migrater #5620
Merged
tests: deflake migrater #5620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes vitessio#5616 After tablets are initialized, the shard master gets updated asynchronoysly. Sometimes, the test races ahead of that update and panics. Test is now changed to wait for shard masters to be udpated, and there's no defensive code in case the master is not set. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
morgo
approved these changes
Dec 23, 2019
systay
pushed a commit
that referenced
this pull request
Jul 22, 2024
* Allow for more flexible parsing `VECTOR` should not be treated as a keyword, because MySQL also still allows it being used as a column name for example in MYSQL 9.0.0 which adds the `VECTOR` type. This doesn't work yet though, it triggers a whole bunch of additional shift/reduce and reduce/reduce warnings: conflicts: 6 shift/reduce, 41 reduce/reduce I have tried many things to resolve this one, but failed so far. One thing that removes the reduce/reduce conflicts is to change the `ALTER TABLE` style syntax to: ``` | VECTOR index_or_key name_opt ``` This means thought that in `ALTER TABLE ... ADD VECTOR INDEX|KEY` the later `INDEX` or `KEY` part is required which doesn't match MySQL for `SPATIAL` and `FULLTEXT` (it's optional there). Like I semantically understand why these conflicts happen, but I'm failing to tell the grammar properly how to resolve them explicitly. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * feat: fix shift-reduce conflict Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: handle reduce reduce conflicts by unrolling the grammar symbol and adding precedence rules Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: account for a newline being removed in sql.y 🤦 Signed-off-by: Manan Gupta <manan@planetscale.com> * Make index or key non-optional Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Reduce upstream diff Makes it easier to avoid conflicts in the future. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> --------- Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5616
After tablets are initialized, the shard master gets updated
asynchronoysly. Sometimes, the test races ahead of that update and
panics.
Test is now changed to wait for shard masters to be udpated, and
there's no defensive code in case the master is not set.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com