Added Consul and Zk2 topo support in Go Cluster endtoend tests #5738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
ajeetj
changed the title
|
Looks like the test failed in github actions. I will fix those tomorrow. |
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
ajeetj
changed the title
deepthi
reviewed
Jan 21, 2020
| Binary: binary, | ||
| Port: port, | ||
| Host: hostname, | ||
| PeerPort: peerPort, |
There was a problem hiding this comment.
do we need to store both PeerPort and PeerURL?
There was a problem hiding this comment.
@deepthi Yes, etcd required these ports.
Python also uses two ports but they name them as clientPort and peerPort.
There was a problem hiding this comment.
Right, we only need PeerURL in this case. I will remove the extra variable.
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved etcd_process.go to topo_process.go
Added support for zk2 and consul
Added Start/Shutdown methods for zk2 and consul
Handle --topo-flavor flag [default to etcd2]