Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate disable_local_gateway flag. #5741

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Jan 20, 2020

This flag should have been removed along with l2vtgate functionality.
Also remove reference to l2vtgate in comments.

Signed-off-by: deepthi deepthi@planetscale.com

…ng with l2vtgate functionality

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi requested a review from sougou as a code owner January 20, 2020 20:31
@deepthi deepthi requested a review from morgo January 20, 2020 20:31
@deepthi
Copy link
Member Author

deepthi commented Jan 20, 2020

@morgo this will need to go into release notes, and we should remember to delete the flag for the next release.

Copy link
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like the mapping of it to _. That makes it easier to keep track of while knowing that it is not in use.

@deepthi deepthi merged commit 0cb011e into vitessio:master Jan 21, 2020
@deepthi deepthi deleted the ds-l2vtgate-cleanup branch January 21, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants