Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test and unit_test targets #5786

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Feb 4, 2020

#5527 removed the definition of the unit_test target and changed test to what used to be unit_test. This PR reverts those changes.

Note that running endtoend go tests using go run test.go (which is what make test calls) is currently not working.

Fixes #5699

Signed-off-by: deepthi deepthi@planetscale.com

…ation tests

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi requested a review from sougou as a code owner February 4, 2020 03:59
@deepthi deepthi requested a review from morgo February 4, 2020 03:59
Copy link
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgo morgo merged commit 157f952 into vitessio:master Feb 4, 2020
@morgo morgo deleted the ds-makefile-tests branch February 4, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review test usage
2 participants