Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount on /private/var/run/syslog in OSX for syslog #5818

Closed
wants to merge 1 commit into from

Conversation

tz70s
Copy link

@tz70s tz70s commented Feb 14, 2020

Not really sure if this is the best solution. In mac, /var (the soft links) can't be mounted from docker directly and therefore either /var/run/syslog as mentioned.

Ref: #5772

Signed-off-by: Tzu-Chiao Yeh su3g4284zo6y7@gmail.com

Signed-off-by: Tzu-Chiao Yeh <su3g4284zo6y7@gmail.com>
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're probably adding this because of the syslog warnings you might be seeing?

If so, I'd instead recommend deleting the code that logs to syslog. It has been a source of problems, and it's been agreed that it's a bad idea to try and write to syslog.

@tz70s
Copy link
Author

tz70s commented Feb 18, 2020

You're probably adding this because of the syslog warnings you might be seeing?

The motivation is the /dev/log can't be mounted on Mac OSX as described in #5772. Currently I can't run tests without any workaround.

If so, I'd instead recommend deleting the code that logs to syslog. It has been a source of problems, and it's been agreed that it's a bad idea to try and write to syslog.

Oh sure I can do it if it's agreed to drop syslog, maybe we need a ticket to track this?

@sougou
Copy link
Contributor

sougou commented Feb 22, 2020

Created #5844. Let's wait a few days to make sure no one objects.

@tz70s
Copy link
Author

tz70s commented Feb 27, 2020

Cool thanks! I'll revise this pr afterwards.

@deepthi
Copy link
Member

deepthi commented Aug 25, 2021

@tz70s are you still interested in fixing #5844? I'm closing this PR for now, please open a new one if you decide to work on this.

@deepthi deepthi closed this Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants