Flexibility to provide backup engine on the helm chart #5850
Conversation
Signed-off-by: Yuvraj <yuvraj.yad001@gmail.com>
Signed-off-by: Yuvraj <yuvraj.yad001@gmail.com>
Signed-off-by: Yuvraj <yuvraj.yad001@gmail.com>
|
@deepthi @derekperkins I am reading the documentation for backup(https://vitess.io/docs/user-guides/backup-and-restore/). Should we provide all flag configurable via helm or just add backup_engine_implementation in the helm. |
I think we should allow all xtrabackup flags to be configurable via helm. |
Signed-off-by: Yuvraj <yuvraj.yad001@gmail.com>
|
@deepthi ready for first round of code review |
Signed-off-by: Yuvraj <yuvraj.yad001@gmail.com>
Signed-off-by: Yuvraj <yuvraj.yad001@gmail.com>
yindia
changed the title
|
I'll defer to @derekperkins for the actual review and approval. Don't know much about helm. |
|
@derekperkins ping |
|
Sorry for the delay. I had one question about indentation on the yaml. Also, if you could add an example to the readme, that'd be great. https://github.com/vitessio/vitess/tree/master/helm/vitess We'll go ahead and merge it after that. |
Signed-off-by: Yuvraj <yuvraj.yad001@gmail.com>
Signed-off-by: Yuvraj <yuvraj.yad001@gmail.com>
|
What's the status on this PR? |
|
It is ready for the review |
@derekperkins ping |
|
Trying to re-run failed tests. |
|
hi @evalsocket can you confirm that the helm example works fine with these changes? Then I can approve and merge. |
|
Now that we're deprecating helm #6439, I think we can close this PR. LMK if anyone has other thoughts. |
Closing now. |
Fixed #5847