Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Kubernetes templates from repository #5873

Merged
merged 4 commits into from
Mar 3, 2020
Merged

Remove deprecated Kubernetes templates from repository #5873

merged 4 commits into from
Mar 3, 2020

Conversation

yindia
Copy link
Contributor

@yindia yindia commented Feb 28, 2020 •
edited by morgo
Loading

Fix #5713

The following related issues will be handled separately:

Yuvraj added 2 commits February 27, 2020 22:18
Remove kubernetes template from example
50bed0a 
Signed-off-by: Yuvraj <yuvraj.yad001@gmail.com>
Remove kubernetes template from example
5148a38 
Signed-off-by: Yuvraj <yuvraj.yad001@gmail.com>
@yindia yindia requested a review from sougou as a code owner February 28, 2020 19:17
@morgo morgo changed the title Deprecate Kubernetes templates from repository Remove deprecated Kubernetes templates from repository Feb 28, 2020
Documentation removed
1eb28af 
Signed-off-by: Yuvraj <yuvraj.yad001@gmail.com>
Update document for docker build
30febaa 
Signed-off-by: Yuvraj <yuvraj.yad001@gmail.com>
@morgo
Copy link
Contributor

morgo commented Mar 1, 2020

LGTM, let's just get another maintainer the chance to review.

(For other reviewers: I chatted with @evalsocket on Slack, and there were a couple of cases we were not quite sure on, such as test/cluster. We are still in the early development of Vitess 6, so I suggested we error on the side of removal. If we are missing some test coverage, we have sufficient time to fix any discovered issues prior to release.)

deepthi
deepthi reviewed Mar 2, 2020
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too.

@morgo
Copy link
Contributor

morgo commented Mar 2, 2020

Alright, if there are no objections I will merge tomorrow.

@morgo morgo self-requested a review March 3, 2020 17:07
@morgo morgo merged commit d18052d into vitessio:master Mar 3, 2020
@hallaroo hallaroo mentioned this pull request Nov 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi left review comments

@morgo morgo morgo approved these changes

@sougou sougou Awaiting requested review from sougou

@derekperkins derekperkins Awaiting requested review from derekperkins

@dkhenry dkhenry Awaiting requested review from dkhenry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Call for maintainers: examples/kubernetes
3 participants
@yindia @morgo @deepthi